libxl: Fix NULL deref in libxl_ctx_free()
authorGianni Tedesco <gianni.tedesco@citrix.com>
Tue, 7 Sep 2010 18:05:17 +0000 (19:05 +0100)
committerGianni Tedesco <gianni.tedesco@citrix.com>
Tue, 7 Sep 2010 18:05:17 +0000 (19:05 +0100)
xc_interface_close() will de-reference a NULL handle, check for this
condition in libxl_ctx_free() before calling.

Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl.c

index 03d9a9380ceab0461093e4c235c76ee284c8e2d5..bd82653c7f1677a9611ad9da87f557d24f18cde7 100644 (file)
@@ -67,7 +67,7 @@ int libxl_ctx_init(libxl_ctx *ctx, int version, xentoollog_logger *lg)
 
 int libxl_ctx_free(libxl_ctx *ctx)
 {
-    xc_interface_close(ctx->xch);
+    if (ctx->xch) xc_interface_close(ctx->xch);
     libxl_version_info_destroy(&ctx->version_info);
     if (ctx->xsh) xs_daemon_close(ctx->xsh); 
     return 0;